dangernoodle-io / breadboard / 30675545686

97%

push

github

refactor: delete dead static-stack branch in bb_ota_check espidf (#1170)

CONFIG_BB_OTA_CHECK_AUTOREGISTER is not declared in any Kconfig (only
referenced in a help-text comment in components/bb_ota_boot/Kconfig).
An undeclared identifier in a C #if evaluates to 0, so the guard
`#if CONFIG_BB_OTA_STATIC_STACK && CONFIG_BB_OTA_CHECK_AUTOREGISTER`
short-circuited false unconditionally on every board that has ever
existed, regardless of CONFIG_BB_OTA_STATIC_STACK. The guarded
static-BSS task-stack/TCB allocation path has never executed on any
board.

This deletes the dead #if branch entirely (both the static buffer
declarations and the try_spawn() static-backing task config),
collapsing to the always-taken dynamic-allocation path unconditionally.
It does NOT simply drop the "&& CONFIG_BB_OTA_CHECK_AUTOREGISTER" term
and leave "#if CONFIG_BB_OTA_STATIC_STACK" live -- doing so would make
the static-stack path go live for the first time ever, an unvalidated
BSS-vs-heap allocation change never exercised on hardware. Whether to
revive static-stack allocation at all is tracked separately as
B1-1333.

CONFIG_BB_OTA_STATIC_STACK now has no remaining reference in this
file; its Kconfig declaration is untouched since other files may still
reference it (B1-1333 decides its fate).

The di_legacy fence baseline shrank 20 -> 19 (autoregister_usage marker
pruned, shrink-only --update-baseline).

B1-1327

8103 of 8676 branches covered (93.4%)

Branch coverage included in aggregate %.

13743 of 13898 relevant lines covered (98.88%)

2581.09 hits per line