dangernoodle-io / breadboard / 30677511662

97%

push

github

refactor: remove vestigial bb_http_reserve_routes route-count mechanism (#1172)

bb_http_reserve_routes() existed to size esp_http_server's
max_uri_handlers from a hand-maintained per-component route count. It
is dead: max_uri_handlers is now sized from the constant
CONFIG_BB_HTTP_MAX_URI_HANDLERS (default 12), and /api/* routes
dispatch through bb_dispatch_api rather than consuming httpd handler
slots, so no consumer on the ESP-IDF side has read the reserved total
since that cutover. The espidf implementation was already a
documented no-op ((void)n;).

Removed end to end:
- both platform implementations of bb_http_reserve_routes (espidf
  no-op, host accumulate-into-counter) and its declaration in
  bb_http_server.h
- all 13 call sites, including 2 inline calls with no wrapper
  (bb_ota_boot.c boot_progress_server_start, bb_wifi_prov.c
  bb_wifi_prov_start)
- 10 *_reserve_routes wrapper functions and their tier=pre_http
  bbtool:init markers (bb_health, bb_openapi, bb_ota_boot, bb_ota_pull,
  bb_ota_check, bb_ota_push, bb_ota_validator, bb_wifi_http's
  bb_wifi_routes_reserve, bb_diag_http's bb_log_register_routes_reserve,
  bb_system's bb_system_routes_reserve) -- 3 more than the ~7 estimated
  going in, found via marker grep rather than name pattern since they
  don't follow the <component>_reserve_routes suffix convention
- the host-only accessors bb_http_host_reserved_routes() /
  bb_http_host_reset_reserved() and their backing s_host_reserved_routes
  static, plus the two host tests that existed solely to validate them
  (test_http_reserve_routes_accumulates,
  test_reserve_declared_total_from_companions)

Kept: the bb_ring_diag/CMakeLists.txt comment referencing an earlier,
already-deleted bb_http_reserve_routes call -- purely historical, not
live code.

Why the two deleted host tests are not a coverage loss worth keeping:
both asserted on s_host_reserved_routes, a counter that nothing on the
real (ESP-IDF) target ever reads -- max_uri_handlers... (continued)

8101 of 8674 branches covered (93.39%)

Branch coverage included in aggregate %.

13740 of 13895 relevant lines covered (98.88%)

2580.95 hits per line