petl-developers / petl / 30491666045

92%

push

github

Fix header instance attribute shadowing Table.header() across views (#704)

Fix header instance attr shadowing Table.header() method across views

Table binds header() as a class method, but many Table subclasses store
their header argument as self.header, silently replacing the method with
data. Calling the fluent .header() then raises TypeError, e.g.
fromcsv(p).header() -> 'NoneType' object is not callable.

Rename the stored attribute to self._header in every affected view, the
same fix #555 applied to fromdicts (renamed header -> _header, released
in 1.7.5 as a bugfix). Covers fromcsv, fromtext, fromjson, fromcolumns,
cat, pushheader, setheader, rowmap, rowmapmany, rowgroupmap, rowreduce,
mergesort and validate; #555 missed the fromjson sibling.

106 of 109 new or added lines in 12 files covered. (97.25%)

13845 of 15101 relevant lines covered (91.68%)

0.92 hits per line