petl-developers / petl / 30330059606

92%

push

github

Fix DictsView.dicts instance attr shadowing Table.dicts() method (#697)

`fromdicts()` returns a `DictsView` that stores its input as
`self.dicts`, which shadows the `dicts()` method `Table` picks up from
`Table.dicts = dicts` in `petl/util/base.py`. The instance attribute
wins attribute lookup, so:

```python
>>> import petl as etl
>>> etl.fromdicts(etl.dummytable().dicts()).dicts()
TypeError: 'DictsView' object is not callable
```

Renames the internal attribute to `self._dicts` in `DictsView` and
`DictsGeneratorView`, following the `self._header` convention 5498411
introduced on this same class for the same collision (released in 1.7.5
as "Fix `fromdicts(...).header()` raising TypeError").

The last commit is separable: it keeps `.dicts` readable as the input
data via a property on `DictsView`, so the attribute behaves as it does
today while `.dicts()` starts working. Drop that commit for the plain
rename.

Fixes #643.

61 of 66 new or added lines in 2 files covered. (92.42%)

13763 of 15027 relevant lines covered (91.59%)

0.92 hits per line