dangernoodle-io / breadboard / 30412441358

97%

push

github

fix: render a save-confirmation HTML page instead of 204 No Content (HW-confirmed) (#1120)

prov_save_handler returned 204 No Content on a successful /save when
no consumer callback was registered. The browser had nothing to
render, and moments later the AP tore down mid-response -- the user
saw a browser error and assumed the save failed, even though it
succeeded.

Add bb_wifi_prov_render_saved_page() (+ bb_wifi_prov_html_escape()),
pure host-testable helpers that build a minimal, self-contained HTML
confirmation naming the network (and hostname/mDNS name, if set),
warning that this SoftAP is about to disappear, and HTML-escaping
both fields -- ssid/hostname are attacker-controlled in the general
case. The response is still fully written before
bb_wifi_prov_signal_done()/wifi_prov_mgr_on_save(), same ordering as
before.

The default form (components/bb_prov_default_form) already submits
via a native <form method="POST" action="/save">, not JS fetch, so
the rendered page is reachable as-is -- no JS change needed.

7887 of 8491 branches covered (92.89%)

Branch coverage included in aggregate %.

38 of 38 new or added lines in 1 file covered. (100.0%)

13411 of 13566 relevant lines covered (98.86%)

2681.29 hits per line