dangernoodle-io / breadboard / 30411262706

97%

push

github

fix: stop eagerly starting the wifi lifecycle service before observers attach (HW-confirmed) (#1119)

floor_app.c called bb_lifecycle_start(wifi) unconditionally at
composition time, before mDNS/MQTT ever registered their observers.
That permanently flipped the service to RUNNING with zero observers
present; the real GOT_IP arriving later via the emit trampoline then
hit bb_lifecycle_start()'s idempotent early-return (no notify, no
version bump), so the STOPPED/PAUSED->RUNNING edge never fired.
Confirmed on hardware: blank-NVS provisioning reached got-ip but mDNS
never started; a provisioned cold boot worked only by accident, via
the blocking connect + bb_wifi_has_ip() bypass in bb_mdns_init_locked.

Leave the service STOPPED at composition time; it now reaches RUNNING
only through the genuine edge, matching the http service's own
register-observer-before-start pattern already in this file.

7852 of 8455 branches covered (92.87%)

Branch coverage included in aggregate %.

13373 of 13528 relevant lines covered (98.85%)

2607.21 hits per line