dangernoodle-io / breadboard / 30410627755

97%

push

github

fix: apply saved credentials when provisioning hands off to reconnect (HW-confirmed) (#1118)

- add connect_fresh_fn to the reconn FSM adapter, wired to a new
  bb_wifi_internal_connect_fresh() that applies the freshly-saved
  SSID/password and issues a connect, unlike the bare esp_wifi_connect()
  connect_fn uses
- route the WR_NO_CREDS/EV_CREDS_ARRIVED row through a new
  act_creds_arrived_connect action that calls connect_fresh_fn instead of
  act_reset_state's connect_fn -- provisioning's own SSID scan and/or AP
  teardown can bring the driver up in STA mode with no config applied
  before EV_CREDS_ARRIVED is posted, which a bare connect silently fails
  against
- keep {WR_LEFT, EV_RECONNECT_REQUESTED} on act_reset_state/connect_fn --
  that row resumes an already-associated session whose driver config is
  already live, unlike a first-time creds-arrived connect
- make bb_wifi_internal_connect_fresh() safe to call whether or not the
  esp_wifi driver is already initialized/started, mirroring the
  driver_inited/cur_mode idiom already used by bb_wifi_ap_start() and
  wifi_ensure_scan_capable() -- calling wifi_connect_sta_ex() directly
  would have crashed via its ESP_ERROR_CHECK(esp_wifi_init()) on exactly
  the state this fix targets, and its blocking wait is unsafe to run
  inside a non-blocking FSM action
- stop discarding esp_wifi_connect()'s return in reconn_connect(); log at
  error level on failure
- cover the new WR_NO_CREDS row with host tests asserting
  connect_fresh_fn (not connect_fn) fires, and contrast WR_LEFT's resume
  row to confirm it still uses the bare connect_fn

7852 of 8455 branches covered (92.87%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

13373 of 13528 relevant lines covered (98.85%)

2605.46 hits per line