zostera / django-bootstrap5 / 30355472208

96%

push

github

Rewrite radio_select.html attrs handling (#851)

Fixes two symptoms of the same root cause: the template manually
reconstructed each <input>'s attributes from a hardcoded whitelist
(value, checked, form, disabled), silently dropping any other attrs
set via a custom create_option() override (#300) — and separately
included Django's generic attrs.html on the wrapper <div>, which
isn't a form-control element, leaking disabled/required/form and an
always-empty class="" onto it (#806).

- Wrapper <div> now only gets id/class explicitly, matching the
  pattern radio_select_button_group.html already uses.
- Each <input> now forwards its own option.attrs generically (id,
  checked, disabled, required, form, and anything custom), excluding
  only `class` (rendered separately via bootstrap_classes to combine
  with server-side-validation classes). This matches Django's own
  stock RadioSelect/CheckboxSelectMultiple rendering, which already
  merges widget-level attrs into each option via option_inherits_attrs.

Net effect: individual radio/checkbox inputs now correctly get
required/disabled (previously only the wrapper div did, which was
itself part of the bug), and #845's ad-hoc `{% if widget.attrs.form %}`
line is no longer needed since option.attrs already includes it.

Added test coverage for CheckboxSelectMultiple (none existed before)
and updated every affected RadioSelect assertion. Confirmed each
change is real by reverting the template and re-running: the new
CheckboxSelectMultiple test and test_disabled_select both fail
cleanly without the fix.

Fixes #300, #806.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

193 of 206 branches covered (93.69%)

Branch coverage included in aggregate %.

663 of 685 relevant lines covered (96.79%)

13.55 hits per line