dangernoodle-io / breadboard / 30224380527

97%

push

github

fix: omit requestBody instead of emitting an empty one on doc-only compose failure (#1103)

Three route descriptors set `request_schema` to a link-time-constant
pointer to their compose buffer, so it was always non-NULL even before
the first compose. bb_openapi_emit.c's `if (route->request_schema)`
gate is pointer-only, so a compose failure (degrade-and-continue,
#1098) left the buffer empty behind a non-NULL pointer and emitted a
schema-less `"application/json": {}` requestBody instead of omitting
it entirely -- same failure mode B1-1242/#1100 fixed for
bb_sensor_http_wire.c's PATCH /api/sensors/fan.

Sites fixed (NULL-then-patch-on-success shape, mirroring #1100):
- bb_storage_http_routes.c: s_storage_delete_route (DELETE
  /api/diag/storage)
- bb_storage_http_routes.c: s_factory_reset_route (POST
  /api/diag/factory-reset)
- bb_system_routes.c: s_reboot_route (POST /api/reboot)

Each descriptor now starts `.request_schema = NULL`, is made mutable
(`static bb_route_t`, gated behind CONFIG_BB_OPENAPI_RUNTIME_META; the
#else arm stays `static const` in .rodata), and its
ensure_*_request_schema_patched() only assigns the buffer pointer on
the BB_OK path.

Also fixed the masking test accessors
(bb_storage_http_delete_get_request_schema_for_test(),
bb_storage_http_factory_reset_get_request_schema_for_test(),
bb_system_reboot_get_request_schema_for_test()): they translated
buf[0]=='\0' into NULL, so tests asserted NULL while production's
pointer was never actually NULL. They now return the real descriptor
field directly.

Added one emit-level regression test per route
(test_bb_storage_http_delete_route_omits_request_body_on_compose_failure,
test_bb_storage_http_factory_reset_route_omits_request_body_on_compose_failure,
test_bb_system_reboot_route_omits_request_body_on_compose_failure):
force a compose failure, register the real production route via the
real init fn, drive bb_openapi_emit_stream(), and assert requestBody
is absent from the parsed document.... (continued)

7800 of 8403 branches covered (92.82%)

Branch coverage included in aggregate %.

13259 of 13414 relevant lines covered (98.84%)

2625.95 hits per line