MushroomObserver / mushroom-observer / 30214515300

99%

main: 99%

push

github

Finish converting the remaining composite errors.add call sites

The 4 sites left pre-resolved last commit (name/validation.rb's
text_name_length/author_length/search_name_indistinct,
concerns/validations.rb's when_message-based date checks) weren't
architecturally different from the other 80 - they just composed
their message from multiple .t/.ti fragments via Ruby string
interpolation instead of a single self-contained tag. Folded each
composition into its own tag template in en.txt (verified
byte-for-byte identical output against the pre-change text via a
runner script before touching any Ruby) so every one becomes a
normal single tag + interpolation-args call:

- validate_name_text_name_too_long / validate_name_author_too_long
  now include their own "Maximum: [maximum]" text instead of
  concatenating the separate `:maximum` tag at the call site.
- validate_name_equivalent_exists now interpolates [name]/[id]
  directly instead of appending them after the colon in Ruby.
- validate_when_selected/validate_when_future/
  validate_when_future_debug replace the shared when_message helper
  (deleted) - validate_when_future embeds a `[:validate_today]`
  reference to preserve the exact composed wording, including the
  pre-existing double-space quirk between the date and "today is".

Also converted field_slip.rb's one remaining site: its Rails-native
`:format` type + `message:` override was never actually required by
anything (grepped for any code checking error type/attribute :format
specifically - none), so it's now a plain bare tag like everything
else, with no message: needed.

Every one of the 84 real errors.add(...) call sites this issue set
out to convert is now a bare deferred tag - no remaining exceptions.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

6 of 7 new or added lines in 3 files covered. (85.71%)

53342 of 53793 relevant lines covered (99.16%)

842.3 hits per line