dangernoodle-io / breadboard / 30211408787

97%

push

github

feat: promote wifi provisioned flag inside the atomic pending-creds commit (#1101)

B1-1235 PR3: bb_settings_wifi_pending_promote() now stages the durable
"provisioned" flag as a 4th key in the same bb_config_staged session as
ssid/pass/try (capacity is caller-sized since PR1/PR2, so widening this
one call site's BB_CONFIG_STAGED_DECLARE cap to 4 no longer taxes every
other bb_storage_txn_t consumer repo-wide). This closes the crash window
B1-807 documented and accepted: previously the flag was a separate
sequential write issued right after the 3-key commit, so a crash between
the two could commit creds while leaving the flag stuck false until the
next validated connect converged it.

Shared edge-gate policy stays single-sourced across both write sites
(B1-807's whole point): a new private helper,
bb_settings_provisioned_notify_transition(), is the ONE place that decides
whether the false->true seam fires, called by both
bb_settings_wifi_provisioned_mark_connected() (the captive-portal
direct-commit path, unchanged) and bb_settings_wifi_pending_promote()
(this PR). Promote reads the flag's prior value before its atomic commit,
then invokes the shared notify only after that commit has durably
succeeded -- never on a failed/aborted commit.

Deletes the crash-window compromise this design note documented in
bb_settings.h, now obsolete.

Adds a test proving ssid/pass/try/provisioned all land together from one
promote call and updates surrounding doc comments to describe the new
atomic shape (existing commit-failure/re-promote/direct-commit tests
already asserted the right post-fix behavior and needed no changes).

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7800 of 8403 branches covered (92.82%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

13259 of 13414 relevant lines covered (98.84%)

2619.89 hits per line