dangernoodle-io / breadboard / 30188366208

97%

push

github

fix: degrade doc-only schema-compose failures in sensor route descriptions (#1100)

components/bb_sensor_http/bb_sensor_http_wire.c: bb_sensor_http_describe_routes()
composes four OpenAPI schemas (GET/PATCH /api/sensors/fan response+request,
GET /api/sensors/power, GET /api/sensors/thermal) under
CONFIG_BB_OPENAPI_RUNTIME_META; each early `return compose_rc;` aborted the
remaining sites and bb_sensor_http_init()'s overall init on any one compose
failure, even though the live GET/PATCH /api/sensors/* wildcard dispatch is
already registered by bb_http_section_init() before this doc-only step runs.

Convert all four checkpoints to log-and-continue (bb_log_w naming the
endpoint and rc), matching the landed bb_diag_meminfo_register() /
bb_storage_http_routes_init() precedent: each ensure_*_patched() call
targets its own dedicated buffer with no shared state, so one site's
failure can't affect another's compose. The function's return value now
reflects only the (still-fatal) route-registration calls below, not a
doc-only compose failure -- no CMakeLists change needed, bb_log was already
a PRIV_REQUIRES dep.

Review fixes:
- HIGH: PATCH /api/sensors/fan's request_schema pointed DIRECTLY at its
  compose buffer (link-time-constant, always non-NULL), so a compose
  failure left a truthy-but-empty buffer behind a non-NULL pointer --
  bb_openapi_emit.c's `if (route->request_schema)` gate always opened
  requestBody, emitting a schema-less `"application/json": {}` instead of
  omitting it. Switched to NULL-then-patch (route struct no longer
  `static const`), matching bb_ota_check_common.c's s_config_post_route
  precedent -- ensure_fan_request_schema_patched() now only patches the
  route field on its SUCCESS path.
- MEDIUM: corrected the doc comment above the compose-failure log block,
  which claimed both a NULL schema and an empty request_schema buffer were
  "both omitted by bb_openapi_emit.c's gates" -- the buffer half was false
  (the HIGH above); now bot... (continued)

7798 of 8401 branches covered (92.82%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

13253 of 13408 relevant lines covered (98.84%)

2690.99 hits per line