orion-ecs / keen-eye / 30200155187

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(input,samples): Distinguish absent input devices from uninitialized input, and play NOVAFALL without a gamepad (#1256)

NOVAFALL died on frame 1 for anyone with no controller plugged in, reporting
"Startup failed: InvalidOperationException: Input not initialized. Wait for
window to load." Two separate defects combined to produce that misleading line.

Engine — honest messages. SilkInputContext's Keyboard/Mouse/Gamepad getters all
threw the SAME "Input not initialized" text, so "this machine has no gamepad"
(the normal case: primaryGamepad stays null when gamepadList is empty) was
indistinguishable from "the window has not loaded". Each getter now reports
which of the two states it is in, names the absent device, and points at the
safe property to test first (ConnectedGamepadCount/Gamepads, Keyboards, Mice).
Gamepads disabled via SilkInputConfig.EnableGamepads gets its own message rather
than posing as missing hardware. IInputContext's XML docs now document the throw
and name the property to check; the old claim that Gamepad returns "a
disconnected placeholder" was never true of this backend.

OnWindowLoad no longer sets initialized = true when the provider yielded no
Silk.NET input context — IsInitialized used to report success while every device
getter failed, which is precisely the lie above. It also hooks
ISilkWindowProvider.OnLoad instead of Window.Load, matching SilkGraphicsContext
and SilkLoopProvider: the provider creates the input context inside its own
window-load handler before raising OnLoad, so InputContext is guaranteed to
exist (and the type becomes testable without opening a window).

Sample — no controller required. InputSteerSystem and GameFlowSystem read
input.Gamepad unguarded every frame; checking gamepad.IsConnected afterwards
cannot help, because the getter has already thrown. Both now resolve devices
through a new InputDevices helper (FirstConnectedGamepad/FirstKeyboard over the
always-safe plural collections), so the game i... (continued)

Coverage Stats

8933 of 13242 branches covered (67.46%)

Branch coverage included in aggregate %.

61 of 95 new or added lines in 7 files covered. (64.21%)

5 existing lines in 4 files now uncovered.

52874 of 83836 relevant lines covered (63.07%)

1.0 hits per line