orion-ecs / keen-eye / 30154512363

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(samples): Report NOVAFALL window-creation failures instead of crashing

The startup guard added in #1258 covered only the game loop, but
SilkWindowPlugin.Install creates the window (initializing GLFW) during plugin
installation, several statements earlier. On a machine with no display the
failure therefore escaped as an unhandled GlfwException instead of the intended
diagnostic - reproduced on a headless host:

  Unhandled exception. Silk.NET.GLFW.GlfwException: GLFW Init failed, 65550:
  Failed to detect any supported platform

The presentation-plugin installs (window, graphics, input) are now inside the
same guard and share one ReportStartupFailure helper with the loop's handler, so
any startup failure prints the exception type and message first and exits
cleanly. Same host now prints:

  Startup failed: GlfwException: GLFW Init failed, 65550: Failed to detect any
  supported platform

The requirement hint is reworded to point at that line rather than compete with
it: a reader who quotes only the hint has been told a guess, not the cause.

Coverage Stats

8887 of 13134 branches covered (67.66%)

Branch coverage included in aggregate %.

0 of 13 new or added lines in 1 file covered. (0.0%)

271 existing lines in 4 files now uncovered.

52722 of 83187 relevant lines covered (63.38%)

1.0 hits per line