djeedai / bevy_hanabi / 30177227450

58%

Build Type

push

github

Committed by web-flow

Commit Message

Pack `EffectMetadata` and bind as array (#553)

Bind the `EffectMetadata` struct describing the per-effect-instance data
as an array. This allows compacting the struct and avoiding
device-mandated padding. This also greatly simplifies the `vfx_indirect`
shader which know can use the typed struct instead of manipulating
type-erased `u32`/`f32` values.

Fix missing GPU thread capping in CPU-based init and in update passes,
to early out when the thread has no particle to process, instead of
doing a useless binary search. GPU-based init continues to do the binary
search, which is anyway currently operating on a single-element array
(no GPU event batching).

Update the `instancing` example to use properties per effect, to prove
property batching works.

Coverage Stats

139 of 320 new or added lines in 7 files covered. (43.44%)

41 existing lines in 2 files now uncovered.

5426 of 9284 relevant lines covered (58.44%)

678.76 hits per line