djeedai / bevy_hanabi
58%

DEFAULT BRANCH: main
Repo Added
Files 32
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 57.546% (-0.2%) from 57.75%
22800469877

push

github

web-flow 
Batch spawners and properties (#525)

Bind the entire spawner and property arrays in all passes, instead of a
single entry. This removes the need to pad those structures. Access them
via an offset in the effect's own metadata.

Add a new `BatchInfo` struct holding the per-batch data. This clarifies
the responsibilites between this and `EffectMetadata`, the latter
holding per-effect (not per-batch) data.

Remove the `DispatchBufferIndices` component, which was used to track
the allocated entry for indirect compute dispatch. Instead, align those
allocations 1:1 with the GPU batch info allocations, which are
re-computed each frame.

Add a prefix sum pass before the update pass, which computes the prefix
sum of alive particles after the init pass. This is used to enable
batched update compute dispatch, where the number of compute threads
maps to the total number of alive particles in the batch. In that case,
we need to find which thread updates which particle of which batch,
using that prefix sum. Note that in this change, due to other
limitations still present, each effect instance is still in its own
batch (there's effectively no batching). Enabling full batching requires
more work, notably on the sort pass for ribbons, and the GPU-based init
pass with GPU events.

Change the allocation of spawners to occur after sorting. This ensures
all effects in a same batch have sequential allocations, which enables
accessing those spawners with a simple {offset + index} strategy.

Change the render pass to use the same bind group "spawner@2" than other
passes. This binds the property buffer, although in this change the
metadata buffer is still not available, so properties can't be used yet
in the render pass. The bind groups should be reviewed anyway because,
with batching approaching, and with the current change, assumptions
about frequency of changes is now wrong, and individual bindings should
be re-grouped in more suitable frequency-based groups.

Finally, the... (continued)

193 of 404 new or added lines in 7 files covered. (47.77%)

26 existing lines in 3 files now uncovered.

4793 of 8329 relevant lines covered (57.55%)

198.51 hits per line

Relevant lines Covered
8329 RELEVANT LINES 4793 COVERED LINES
198.51 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
22800469877 main Batch spawners and properties (#525) Bind the entire spawner and property arrays in all passes, instead of a single entry. This removes the need to pad those structures. Access them via an offset in the effect's own metadata. Add a new `BatchInf... push web-flow github
57.55
22800193808 u/prop-spawn-full Merge 03943ec8f into 2103829dd Pull #525 web-flow github
57.55
22798556496 u/prop-spawn-full Merge 811edc141 into 2103829dd Pull #525 web-flow github
57.79
22798486531 u/prop-spawn-full Merge 9ec6a7dd3 into 2103829dd Pull #525 web-flow github
57.79
22264614914 main feat(lightning): add vertical lightning example (#515) hello peoples in the discord seemed to like it https://discord.com/channels/691052431525675048/1036006050526142514/1452071425983905932 first time using hanabi, some things might not be opti... push web-flow github
57.75
22263909674 main Clean-up bind groups with Bevy utils (#524) Use the Bevy utils to shorten the bind group layout and bind group creation and make the code more readable. Rename all bind group GPU resources to `bg` and the layout ones to `bgl` to make them shorte... push web-flow github
57.75
22263661484 u/bgl Merge 8c2b17889 into db782db43 Pull #524 web-flow github
57.75
21566577471 main v0.18.0 push djeedai github
58.35
21565652705 lightning-example Merge 3fbb7f85c into ea57ad23b Pull #515 web-flow github
58.35
21565578469 main Update to Bevy v0.18 (#521) Thanks to @morgenthum for the original work. push web-flow github
58.35
See All Builds (899)