ruby-grape / grape / 30172405085

97%

master: 97%

Pull #2819

github

Freeze coercers at construction and synchronize Grape::Util::Cache

Extends the validator freeze contract to the whole coercion layer,
naming the mechanism as Grape::Util::FreezeOnNew — extend into a class
whose instances are shared across requests and new returns a frozen
instance. A future request-time lazy ivar write raises FrozenError in
the first spec run instead of being a latent race. The module wraps new,
never initialize, so the freeze lands after the entire initialize chain
(SetCoercer assigns ivars after super); extending a hierarchy base
covers its subclasses via singleton-class inheritance.

- Extended into DryTypeCoercer (covers Primitive/Array/Set),
  CustomTypeCoercer (+ collection subclass), MultipleTypeCoercer
  (internal @type_coercers also frozen) and VariantCollectionCoercer.
  Validators::Base's hand-written new/super.freeze and
  ContractScopeValidator's end-of-initialize freeze now use the same
  module. DeepFreeze's obsolete "coercers memoize lazily" note updated.

- Grape::Util::Cache lookups are Monitor-synchronized. The caches are
  written at API *definition* time (params blocks run at class-body
  evaluation), which the compile-time Instance::LOCK does not cover and
  which can be concurrent (parallel eager loading, concurrent autoload
  of different API files). Monitor rather than Mutex because CoercerCache
  re-enters itself when a multiple-type coercer builds member coercers.

- Route#regexp_capture_index is assigned eagerly in #to_regexp instead
  of memoized on first read: the reader runs during request-time route
  matching on shared instances. Previously safe only because to_regexp
  happened to warm it during compilation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

1137 of 1230 branches covered (92.44%)

Branch coverage included in aggregate %.

3758 of 3825 relevant lines covered (98.25%)

22893.09 hits per line