ruby-grape / grape / 30170426685

97%

master: 97%

Pull #2817

github

Remove request-time mutable state from Array/custom coercers

Two coercers created or mutated state at request time on instances that
are shared across requests (and cached in Types::CoercerCache):

- ArrayCoercer memoized @elem_coercer with ||= inside #call, so the
  first request to hit a shared instance wrote a new ivar (and could
  seed the unsynchronized DryTypes cache). Build it eagerly in
  initialize instead; rename the now-unused @subtype accordingly.
  SetCoercer inherits the eager build via super.

- CustomTypeCoercer#collection_symbolizer called map! on whatever the
  user's coerce_with method returned. A frozen return raised FrozenError,
  which CoerceValidator swallowed as a spurious "is invalid" 400; the
  input could also be the user's own object. dup before map! avoids the
  mutation and, unlike map, keeps a Set a Set.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

1137 of 1230 branches covered (92.44%)

Branch coverage included in aggregate %.

3747 of 3814 relevant lines covered (98.24%)

22746.17 hits per line