dangernoodle-io / breadboard / 30139494805

96%

push

github

refactor: move openapi tree emitter host-only and drop bb_json dependency (#1065)

- relocate bb_openapi_emit() and its tree-specific build_operation() to
  platform/host/bb_openapi/bb_openapi_emit_tree.c, mirroring the
  bb_openapi_validate.c precedent -- zero device callers, but load-bearing
  for host_tools/emit_openapi and the host test suites
- extract plumbing shared by both emitters (schema registry, method_str,
  derive_operation_id, path_set_*, collect_paths_walker,
  build_sse_oneof_fragment) into bb_openapi_emit_shared.c, declared in the
  existing bb_openapi_emit_internal.h, so device and host-only emitters
  derive identically without duplicating logic
- drop bb_openapi_emit()'s declaration and bb_json.h from the public
  bb_openapi.h; add a host-only bb_openapi_emit_tree_priv.h for the
  relocated declaration
- drop bb_json from bb_openapi's idf_component_register REQUIRES -- this
  is the removal of the last bb_json REQUIRES/PRIV_REQUIRES edge in the
  ESP-IDF firmware build. cJSON itself stopped being linked into the
  firmware image back at #1064 (--gc-sections incidentally stripped the
  already-dead-on-device tree emitter once emit_operation()/
  bb_openapi_emit_stream() took over the live route); this PR makes that
  removal structural instead of incidental -- with the REQUIRES edge and
  source-tree coupling gone, cJSON can no longer silently reappear the
  next time someone adds a bb_json_t reference to this component. Flash
  size is therefore unchanged from #1064, not reduced by this PR
- re-point host_tools/emit_openapi and the affected host tests at the
  relocated tree emitter's header
- add sse_schema_count() to avoid a bounds-check branch that's
  unreachable inside an already-bounded loop (would otherwise regress
  branch coverage)

7780 of 8377 branches covered (92.87%)

Branch coverage included in aggregate %.

235 of 235 new or added lines in 3 files covered. (100.0%)

13253 of 13411 relevant lines covered (98.82%)

2517.43 hits per line