dangernoodle-io / breadboard / 30138613842

97%

push

github

refactor: emit device openapi via bb_http_resp_json_obj instead of bb_json (#1064)

- rewrite bb_openapi_emit_stream() and add emit_operation() to write the
  streamed OpenAPI document field-by-field via bb_http_resp_json_obj_*,
  so the device route handler no longer calls any bb_json_* function
- bb_openapi_emit_stream() now owns the whole chunked response lifecycle
  (begin sets Content-Type + opens the response, end always flushes and
  sends the terminator, even on error); the route handler
  (bb_openapi_register.c) no longer sets Content-Type or sends its own
  terminator chunk, avoiding a double-terminate of the response
- drop the now-obsolete LCOV_EXCL_BR_LINE markers from the old per-chunk
  error-checking code, replaced by the primitive's sticky-error handling
- add stream-path fixtures covering emit_operation()'s null/absent-field
  branches (summary, parameter name/in/description/schema_type, request
  content-type, response description/content-type, zero SSE topics) and
  the bb_http_resp_json_obj_begin() failure path, plus a stream-path
  counterpart to the SSE oneOf overflow test, closing a branch-coverage
  gap the structural equivalence harness alone did not exercise
- qualify the bb_openapi_emit_stream() doc comment: the response is only
  guaranteed finalized once it has actually been opened
- note that request/response schema literals are non-empty by
  route-table convention, since bb_http_resp_json_obj_set_raw rejects a
  zero-length raw value
- bb_openapi_emit() (tree) and build_operation() are unchanged; they
  still back the host validator/fidelity tests and the tree path

7784 of 8381 branches covered (92.88%)

Branch coverage included in aggregate %.

99 of 99 new or added lines in 1 file covered. (100.0%)

13250 of 13408 relevant lines covered (98.82%)

2578.22 hits per line