Geoffery10 / Discord-Role-Manager / 29950793573

90%

push

github

Skip guilds the bot is no longer in (was crashing the daily task loop)

update() iterated the hardcoded guilds list in main.py and called
client.get_guild(id).name on each entry. If the bot had been removed
from a server since the list was last updated, get_guild returned
None and the .name access raised AttributeError, killing the loop
mid-iteration. Every guild after the stale one silently got skipped
— which is why The Canvas birthday message never posted after the
bot was (re-)added to a stale-id list, and why subsequent guilds
like Terrarium also never got processed.

Wrap the lookup in a None-check: log a WARNING naming the stale id
and continue, so the rest of the guilds still get their daily pass.
Same treatment for the database-sync phase below.

Adds a regression test that pins the new behavior: with a None
guild in the middle of the list, the other two guilds still get
check_birthday called, and a warning is logged for the stale id.

28 of 28 new or added lines in 2 files covered. (100.0%)

2192 of 2703 relevant lines covered (81.1%)

0.81 hits per line