Geoffery10 / Discord-Role-Manager / 29950204037

90%

push

github

Silence no-op role logs and batch guild-user membership query

- role_handler: add_role and remove_role now return a Result namedtuple
  (did_work, message) instead of a bare string. did_work is True only
  when the Discord API was actually called. The 'user does not have the
  role' no-op returns did_work=False, which the caller uses to skip
  the log line — this was spamming one INFO per non-birthday user per
  day (thousands of lines per run across 6 guilds).
- birthday.check_birthday: replace the per-user is_user_in_guild() loop
  with a single get_guild_users(guild.id) call. One SQL query instead
  of N round-trips per guild. Visibly faster on the bot server
  (~19s/guild dropped to <1s for ~200 users).
- tests/test_role_handler: update 16 tests to access .message and
  .did_work on the new Result. Behavior coverage unchanged; the
  no-op assertion is now explicit (did_work is False and remove_roles
  is not awaited).

42 of 44 new or added lines in 3 files covered. (95.45%)

2166 of 2677 relevant lines covered (80.91%)

0.81 hits per line