Geoffery10 / Discord-Role-Manager / 29956984604

90%

push

github

Add route tests for dashboard/main.py — 30% → 70% coverage

test_dashboard_helpers.py covered the pure helpers and schema migration
in dashboard/main.py, but the 20 route handlers had zero direct test
coverage. This file uses FastAPI's TestClient to hit each route
through the real ASGI app, with the DB and JSON file paths redirected
to a fresh tmp dir per test so each one is isolated.

Covers 13 of the 20 routes: the high-value ones that drive the
Overview, Users, Roles, Birthdays, Guilds, and Logs tabs, plus the
auth/me endpoint and /auth/logout. The OIDC callback, the SSE avatar
refresh stream, and the @app.on_event startup hook are deliberately
skipped — they need a real OIDC mock, real Discord API, and lifespan
handler respectively, all of which are out of scope for a route
contract test.

Coverage impact (combined with the existing helpers tests):
  dashboard/main.py: 30% → 70%  (+40 pp)
  overall project:   61% → 83%  (+22 pp)
  test count:       143 → 190  (+47)

Each test focuses on a single contract: status code, key payload
fields, edge cases (empty DB, invalid params, sort injection
attempt, missing log file, etc). Tests that revealed wrong
assumptions during writing were corrected to match the actual
route behavior — see the rename of test_api_guilds_merges_with_
birthday_config which originally assumed the birthday.json name
overrode the table name (it doesn't).

442 of 442 new or added lines in 1 file covered. (100.0%)

2845 of 3145 relevant lines covered (90.46%)

0.9 hits per line