Geoffery10 / Discord-Role-Manager / 29947658365

90%

push

github

Fix birthday drop in cold-cache guilds, remove-role log crash, and per-user debug spam

- check_birthday: filter members via the user_guilds table instead of
  guild.get_member(). get_member is cache-only, so any guild with a cold
  member cache (e.g. a newly-joined server) had every user filtered out
  and no birthday messages sent. The Canvas was hitting this in prod.
- check_user: drop the stray .encode('utf-8') on the remove_role success
  log call. log() then called str.replace on the bytes object, raising
  TypeError, which was caught and re-logged at HIGH severity for every
  non-birthday user with a configured birthday_role.
- check_birthday: collapse the per-user debug log into a single per-guild
  line, cutting log volume by orders of magnitude on multi-guild bots.
- tests/test_birthday: replace guild.get_member mocks with add_user_to_guild
  seeds so the membership filter is exercised against the real DB.

4 of 4 new or added lines in 2 files covered. (100.0%)

2157 of 2666 relevant lines covered (80.91%)

0.81 hits per line