dangernoodle-io / breadboard / 29944286293

96%

push

github

refactor: migrate host-side bb_json emitters off bb_json (B1-1149) (#1000)

- bb_wifi_emit_status (platform/host/bb_wifi_http/bb_wifi_http_emit.c):
  deleted outright, not ported -- its sole caller was a host test fixture
  (test_route_fidelity.c h_health), never a production route. bb_health's
  real /api/health handler never called it either; it already gathers
  ssid/bssid/ip/connected directly and renders through bb_health_wire_desc
  (a bb_serialize_desc_t). The test fixture now mirrors that same
  production gather + bb_health_wire_desc render, matching the h_wifi_info
  fixture's own "call the real descriptor" precedent, instead of hand-
  rolling bb_json.
- bb_mdns_cache_txt_serialize (platform/host/bb_mdns_cache/
  bb_mdns_cache_txt.c): deleted -- its only production caller,
  entry_serialize(), was itself deleted in B1-1146b, leaving only its own
  host test as caller. The identical TXT-field walk lives on, on the wire-
  descriptor path, in bb_mdns_cache_entry_wire_fill(); keeping this bb_json
  mirror would have been a second, dead implementation of the same shape.
- bb_json dropped from bb_wifi_http's and bb_mdns_cache's CMakeLists
  REQUIRES (verified no other file in either component includes bb_json.h)
- stale-comment sweep across bb_wifi.h, bb_wifi_http.h/README.md,
  bb_health_wire_priv.h, bb_mdns_cache.h/wire_priv.h, and the touched test
  files
- dropped the now-dead #include "bb_json.h" from
  test/test_host/test_route_fidelity.c (zero bb_json_* calls remain there)

NULL-safety contract note: bb_mdns_cache_entry_wire_fill() does not
guard dst/entry -- it unconditionally memset()s dst and dereferences entry.
The two tests this deletion removed (bb_mdns_cache_txt_serialize_null_obj_is_noop,
_null_entry_is_noop) asserted a defensive no-op on NULL under the old
bb_json emitter. That defensive contract is intentionally narrowed here to
caller-must-guarantee-non-NULL, matching the bb_wifi_http_info_wire_fill()
precedent (components/bb_w... (continued)

7404 of 7994 branches covered (92.62%)

Branch coverage included in aggregate %.

12547 of 12709 relevant lines covered (98.73%)

2439.72 hits per line