dangernoodle-io / breadboard / 29926492498

96%

push

github

refactor!: reduce bb_cache.h to REQUIRES bb_core (B1-1119) (#999)

BREAKING: removes the bb_cache legacy serialize API (bb_cache_serialize_fn,
cfg->serialize, bb_cache_serialize_into(), bb_cache_get_serialized()) and
deletes the GET /api/diag/cache route entirely -- both zero-producer,
zero-caller by the time of this PR (verified via full-tree grep). Retires
test_bb_cache_fidelity.c's original "event == REST via the same serializer"
guarantee as a TESTED property: it is now true BY CONSTRUCTION (a single
bb_data_render() path, not two independent serialize call sites that could
drift), so there is nothing left to prove with a byte-equality test.

- drop bb_cache_serialize_fn typedef, cfg->serialize field,
  bb_cache_serialize_into(), bb_cache_get_serialized() -- the legacy
  bb_json serialize slot; zero producers register .serialize anymore
  (verified: only the mechanism's own type/dispatcher/synthetic test
  mocks survived, per B1-1146b #998)
- remove serialize_locked() and the memoized cached_json/dirty/fn
  entry fields from platform/espidf/bb_cache/bb_cache_espidf.c (shared
  verbatim by the host build) -- dead weight once the only callers are
  gone
- bb_cache's CMakeLists.txt REQUIRES drops to bb_core (was bb_core
  bb_json)
- delete GET /api/diag/cache (bb_diag_routes.c) and its
  bb_diag_cache_route_status mapper + Kconfig knob + tests, plus the
  route's mention in bb_diag.h's bb_diag_routes_init() doc comment:
  every producer had already migrated off .serialize, so the route had
  degenerated to an unconditional 404/501 debug dump with no
  remaining data source
- drop bb_wifi_http_routes.c's dormant cache-hit branch in
  wifi_info_handler() (bb_cache_get_serialized on a topic no producer
  ever registers) -- always falls through to the live read now; drops
  the now-unused bb_cache PRIV_REQUIRES from bb_wifi_http
- rewrite the four bb_cache test files that used synthetic
  .serialize mocks to exercise the mechanism itself
  (test_bb_cache... (continued)

7418 of 8008 branches covered (92.63%)

Branch coverage included in aggregate %.

12563 of 12725 relevant lines covered (98.73%)

2450.26 hits per line