tomerfiliba / plumbum / 29888045439

88%

Build Type

push

github

Committed by web-flow

Commit Message

fix: harden subprocess and pipeline lifecycle handling (#822)

* fix: harden subprocess and pipeline lifecycle handling

Addresses several subprocess/pipeline lifecycle robustness issues:

- bgrun: wrap the yield in try/finally so the process is always reaped
  and pipes closed even if the with-body raises (incl. KeyboardInterrupt);
  the existing was_run guard keeps reaping to exactly once.
- CommandNotFound: pass (program, path) to super().__init__ instead of
  (self, program, path), fixing repr and pickling.
- timeout heap: add a monotonic counter tiebreaker so equal deadlines
  never make heapq compare uncomparable Popen objects and kill the
  singleton timeout thread.
- Pipeline.formulate: bind call-time args to the source command, matching
  popen's behaviour (e.g. (a | b)("x") -> a x | b).
- Pipeline.popen: close the source's leaked stderr/stdin pipes after both
  stages are reaped.
- async TEE: read stdout/stderr in fixed-size chunks (readline raises past
  the 64KiB limit) with a single incremental decoder per stream to keep
  multibyte chars intact across chunk boundaries; kill/reap the subprocess
  on any failure, not only on timeout.
- daemons: use ProcessLookupError/PermissionError instead of errno checks
  (EPERM means the process exists), accept and ignore wait(timeout=...),
  and use subprocess.DETACHED_PROCESS.

Refs #820

Assisted-by: ClaudeCode:claude-opus-4.8

* test: fix lint and make pipeline-args test path-agnostic for Windows

Addresses CI failures on #822: drop unused unpacked var, combine nested
with-statements (ruff), and assert pipeline arg placement by splitting on
the pipe so it tolerates absolute exe paths on Windows.

Assisted-by: ClaudeCode:claude-opus-4.8

* fix: kill process on bgrun body exception; honor daemon wait timeout

On an exceptional exit from bgrun, terminate (then kill) and reap the
process instead of waiting for natural completion, and skip return-code
validation so the body's exception is not delayed or... (continued)

Coverage Stats

1346 of 1797 branches covered (74.9%)

62 of 73 new or added lines in 4 files covered. (84.93%)

1 existing line in 1 file now uncovered.

5547 of 6341 relevant lines covered (87.48%)

12.41 hits per line