tomerfiliba / plumbum / 29888256867

88%

Build Type

push

github

Committed by web-flow

Commit Message

fix(cli): correct several CLI parsing and terminal bugs (#824)

* fix: correct several CLI parsing and terminal bugs

Fixes a batch of bugs in plumbum/cli/:

- switches.py Set._call_iter: add a `return` after the CSV split loop so the
  whole unsplit string is no longer also validated (CSV("a,b") now yields
  ['a','b'] instead of ['a','b','a,b']).
- switches.py Set: case-insensitive matching now yields the configured
  (canonical) spelling instead of the lowercased user input, so
  Set("TCP","UDP")("tcp") returns "TCP". BEHAVIOR CHANGE for existing
  case-insensitive Sets.
- application.py: an exact switch name now always wins over abbreviation, so
  with --foo and --foobar defined, --foo is no longer rejected as ambiguous.
- application.py: a no-argument switch given --flag=value now raises a clear
  SwitchError instead of leaking '=value' into positional args.
- application.py helpall: no longer mutates the shared SwitchInfo objects when
  demoting meta-switches; the regrouping is now local to the render via a
  transient _hide_meta_switches flag, so subsequent --help output is unaffected.
- application.py _validate_args: unknown names in requires=/excludes= now raise
  a clear SwitchError naming the offending switch instead of a bare KeyError.
- terminal.py: readline() now raises EOFError at end-of-file; ask/choose/prompt
  fall back to their default on EOF or re-raise when there is none, fixing an
  infinite loop on closed/exhausted stdin.
- image.py best_aspect: fix inverted aspect math so a wide image renders wide
  and a tall image renders tall within the terminal box.

Adds regression tests for each fix.

Refs #820

Assisted-by: ClaudeCode:claude-opus-4.8

* Apply suggestions from code review

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>

* refactor: drop Set canonical-spelling change (moved to #835)

The case-insensitive canonical-spelling behavior change moved to its own
PR (#835) so this PR stays bug-fixes-only. The CSV ret... (continued)

Coverage Stats

1359 of 1805 branches covered (75.29%)

39 of 40 new or added lines in 4 files covered. (97.5%)

1 existing line in 1 file now uncovered.

5582 of 6363 relevant lines covered (87.73%)

12.45 hits per line