tomerfiliba / plumbum / 29882703861

88%

push

github

fix: path/fs edge cases (access, unlink, chown, locked) (#825)

* fix: correct path/fs edge cases in access, unlink, chown, locked

Addresses several correctness bugs in the path and fs layers (#820):

- remote.RemotePath.access: handle F_OK (mode 0) as an existence check and
  test the "other" permission bits, not just owner/group; documented as a
  best-effort check that does not compare the caller's uid/gid.
- remote.RemotePath.unlink: no longer aliases delete() (rm -rf); it now
  refuses to recursively remove a real directory (raises EISDIR) and uses a
  non-recursive `rm -f` for files/symlinks, matching os.unlink.
- local.LocalPath.chown: pass -1 for an unspecified owner/group ("leave
  unchanged") instead of re-applying the parent's current uid/gid to every
  walked child.
- fs.AtomicFile.locked: honor blocking=False for the in-process thread lock
  too, raising OSError(EAGAIN) instead of hanging when another thread holds
  the lock.

Adds regression tests for the locally-testable fixes and pure-logic unit
tests for the remote access/unlink behavior (no SSH required).

Assisted-by: ClaudeCode:claude-opus-4.8

* fix: use lstat for remote unlink and require all access bits

Follow-up review fixes for the previous commit:

- RemotePath.unlink now checks link metadata via a new _path_lstat. On
  ParamikoMachine, SFTP stat follows symlinks, so a symlink to a
  directory was wrongly rejected as a directory and a dangling symlink
  was silently left in place. The shell backend's stat (no -L) already
  reports the link itself. The Paramiko lstat path also labels symlinks,
  so is_symlink() now works there.
- RemotePath.access now requires every requested permission bit instead
  of passing when any one bit matched, so a read-only file no longer
  satisfies access(os.R_OK | os.W_OK).

Assisted-by: ClaudeCode:claude-fable-5

1340 of 1792 branches covered (74.78%)

34 of 38 new or added lines in 4 files covered. (89.47%)

5529 of 6317 relevant lines covered (87.53%)

12.42 hits per line