iotaledger / iota / 29883424813
69%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1127
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.081% (+0.2%) from 68.842%
29883424813

push

github

web-flow 
refactor: replace SignatureScheme with the SDK enum (#12342)

# Description of change

Replaces the node's `SignatureScheme` enum with a re-export of
`iota_sdk_types::SignatureScheme` (part of #11590; flag bytes and
lowercase display strings already matched). The SDK-side prerequisite
(`FromStr` for `SignatureScheme`, iotaledger/iota-rust-sdk#1272) is
merged and the SDK rev is bumped to its `develop` merge commit.

- call sites move to the SDK API: `flag()` → `to_u8()`,
`from_flag`/`from_flag_byte` → `from_byte`, `FromStr` via strum (same
lowercase strings, so CLI parsing is unchanged)
- the deprecated flag-5 zkLogin leftovers
(`SignatureScheme::ZkLoginAuthenticatorDeprecated`,
`PublicKey::ZkLoginDeprecated`) are removed; flag `0x05` stays reserved
— the SDK rejects it at parsing
- the redundant `IotaSignature::signature_scheme()` accessor (the SDK's
inherent `scheme()` replaces it) and the unused `scheme` parameter of
`IotaSignature::verify_secure` are dropped

BCS/wire formats are unaffected — the scheme is serialized only as its
flag byte, and `SignatureScheme` does not appear in the staged format
registry.

## Links to any relevant issues

Part of #11590 — addresses the `SignatureScheme` replacement listed in
[this
follow-up](https://github.com/iotaledger/iota/issues/11590#issuecomment-4939381116).

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

`cargo check --workspace --all-targets` clean; `iota-types` (201),
`iota-keys` (14), and keytool (17) unit tests pass locally.

### Release Notes

- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [x] CLI: the `keyScheme` field in `iota client new-address` JSON
o... (continued)

25 of 50 new or added lines in 11 files covered. (50.0%)

2342 existing lines in 68 files now uncovered.

169103 of 244790 relevant lines covered (69.08%)

507436.75 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
69.35
 -0.17% crates/iota/src/client_commands.rs
5
80.29
 0.59% crates/iota-types/src/crypto.rs
5
18.14
 -0.24% crates/iota/src/iota_commands.rs
4
38.67
 -0.3% crates/iota/src/keytool.rs
2
77.24
 0.0% crates/iota-keys/src/key_derive.rs
2
0.0
 0.0% crates/iota-ledger/src/lib.rs
1
0.0
 0.0% crates/iota-ledger/src/api/get_public_key.rs

Coverage Regressions

Lines Coverage ∆ File
300
83.21
 0.22% crates/iota-core/src/authority.rs
239
44.87
 0.08% crates/iota-replay/src/replay.rs
219
82.73
 -0.15% crates/iota-types/src/transaction.rs
120
13.2
 0.05% crates/iota-rpc-loadgen/src/payload/rpc_command_processor.rs
111
85.87
 0.45% crates/iota-json-rpc/src/read_api.rs
105
84.12
 0.0% crates/iota-transactional-test-runner/src/test_adapter.rs
95
93.64
 -0.2% crates/starfish/core/src/authority_service.rs
78
86.04
 0.97% crates/iota-core/src/transaction_orchestrator.rs
71
96.77
 0.19% crates/starfish/core/src/dag_state.rs
68
92.43
 0.0% crates/iota-faucet/src/faucet/simple_faucet.rs
68
96.09
 1.02% crates/starfish/core/src/transactions_synchronizer.rs
60
89.55
 0.0% crates/iota-core/src/authority/suggested_gas_price_calculator.rs
58
38.67
 -0.3% crates/iota/src/keytool.rs
55
94.32
 0.02% crates/starfish/core/src/authority_node.rs
54
92.83
 3.32% crates/starfish/core/src/commit_syncer/fast.rs
41
73.53
 -1.85% crates/iota-types/src/error.rs
39
94.39
 1.66% crates/iota-core/src/consensus_adapter.rs
36
81.38
 -0.17% crates/iota-core/src/authority_aggregator.rs
35
95.76
 2.18% crates/starfish/core/src/shard_reconstructor.rs
32
93.18
 -0.01% crates/iota-core/src/transaction_manager.rs
32
95.51
 1.31% crates/starfish/core/src/leader_schedule.rs
30
97.04
 0.0% crates/iota-core/src/authority/shared_object_congestion_tracker.rs
27
92.86
 0.0% crates/iota-core/src/authority/consensus_quarantine.rs
23
75.39
 -0.1% crates/test-cluster/src/lib.rs
22
90.26
 -0.18% crates/iota-types/src/base_types.rs
21
50.66
 0.87% crates/iota-analytics-indexer/src/handlers/mod.rs
21
90.64
 -0.63% crates/iota-core/src/authority/authority_per_epoch_store.rs
21
94.57
 0.0% crates/iota-single-node-benchmark/src/benchmark_context.rs
21
91.95
 0.45% crates/starfish/core/src/header_synchronizer.rs
17
47.56
 -4.13% crates/iota-types/src/iota_sdk_types_conversions.rs
14
69.56
 -1.14% crates/iota-core/src/authority/authority_store.rs
14
92.02
 0.06% crates/starfish/core/src/leader_timeout.rs
13
94.71
 0.0% crates/iota-core/src/checkpoints/checkpoint_executor/mod.rs
13
72.82
 -6.31% crates/iota-proc-macros/src/lib.rs
11
0.0
 0.0% crates/iota-analytics-indexer/src/handlers/transaction_objects_handler.rs
11
79.09
 -1.2% crates/starfish/core/src/commit_syncer/mod.rs
10
52.94
 -0.34% crates/iota-types/src/full_checkpoint_content.rs
10
44.16
 -12.99% crates/iota-types/src/messages_grpc.rs
10
96.24
 0.07% crates/starfish/config/src/parameters.rs
10
82.86
 0.0% crates/starfish/core/src/error.rs
9
90.88
 -1.35% crates/iota-core/src/consensus_handler.rs
8
91.0
 0.57% crates/starfish/core/src/context.rs
7
63.37
 -0.21% crates/iota-json-rpc-types/src/iota_transaction.rs
7
89.98
 1.84% crates/iota-test-transaction-builder/src/lib.rs
6
46.9
 -2.65% crates/iota-genesis-builder/src/stardust/types/snapshot.rs
6
72.11
 -4.08% crates/iota-json-rpc-types/src/lib.rs
6
91.85
 -4.44% crates/iota-package-management/src/lib.rs
6
78.32
 -2.1% crates/iota-sdk/src/lib.rs
5
78.68
 -0.41% crates/iota-core/src/traffic_controller/mod.rs
5
65.55
 -0.11% crates/iota-types/src/storage/mod.rs
4
49.49
 0.0% crates/iota-sdk/src/apis/read.rs
4
85.51
 -5.8% crates/iota-types/src/quorum_driver_types.rs
4
80.23
 0.0% crates/iota-types/src/signature_verification.rs
4
86.21
 -6.9% crates/iota-vm-sdk/src/executor/types.rs
3
71.43
 -14.29% crates/iota-config/src/certificate_deny_config.rs
3
72.43
 -0.17% crates/iota-core/src/authority_server/validator.rs
3
91.45
 -0.13% crates/iota-core/src/execution_cache/writeback_cache.rs
3
88.36
 -0.26% crates/iota-genesis-builder/src/lib.rs
3
82.14
 -2.68% crates/iota-genesis-builder/src/validator_info.rs
2
85.64
 -0.49% crates/iota-core/src/storage.rs
2
90.71
 -0.24% crates/iota-network/src/state_sync/mod.rs
1
95.48
 0.0% crates/iota-core/src/authority/authority_test_utils.rs
1
89.69
 -0.34% crates/iota-core/src/connection_monitor.rs
1
98.62
 -0.28% crates/iota-core/src/signature_verifier.rs
1
0.0
 0.0% crates/iota-indexer/src/optimistic_indexing.rs
1
89.03
 -0.14% crates/iota-network/src/discovery/mod.rs
1
75.47
 0.14% crates/iota-network/src/randomness/mod.rs
1
85.42
 16.67% crates/iota-network-stack/src/anemo_ext.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 29883424813.1 1127
69.08
 GitHub Action Run
Source Files on build 29883424813