iotaledger / iota / 29883424813

push

github

refactor: replace SignatureScheme with the SDK enum (#12342)

# Description of change

Replaces the node's `SignatureScheme` enum with a re-export of
`iota_sdk_types::SignatureScheme` (part of #11590; flag bytes and
lowercase display strings already matched). The SDK-side prerequisite
(`FromStr` for `SignatureScheme`, iotaledger/iota-rust-sdk#1272) is
merged and the SDK rev is bumped to its `develop` merge commit.

- call sites move to the SDK API: `flag()` → `to_u8()`,
`from_flag`/`from_flag_byte` → `from_byte`, `FromStr` via strum (same
lowercase strings, so CLI parsing is unchanged)
- the deprecated flag-5 zkLogin leftovers
(`SignatureScheme::ZkLoginAuthenticatorDeprecated`,
`PublicKey::ZkLoginDeprecated`) are removed; flag `0x05` stays reserved
— the SDK rejects it at parsing
- the redundant `IotaSignature::signature_scheme()` accessor (the SDK's
inherent `scheme()` replaces it) and the unused `scheme` parameter of
`IotaSignature::verify_secure` are dropped

BCS/wire formats are unaffected — the scheme is serialized only as its
flag byte, and `SignatureScheme` does not appear in the staged format
registry.

## Links to any relevant issues

Part of #11590 — addresses the `SignatureScheme` replacement listed in
[this
follow-up](https://github.com/iotaledger/iota/issues/11590#issuecomment-4939381116).

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

`cargo check --workspace --all-targets` clean; `iota-types` (201),
`iota-keys` (14), and keytool (17) unit tests pass locally.

### Release Notes

- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [x] CLI: the `keyScheme` field in `iota client new-address` JSON
o... (continued)

25 of 50 new or added lines in 11 files covered. (50.0%)

169103 of 244790 relevant lines covered (69.08%)

507436.75 hits per line