hyperledger / fabric-x-committer / 29830255468
91%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 128
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.405% (+0.2%) from 91.23%
29830255468

push

github

web-flow 
[cmd] Inline command's functions (#695)

#### Type of change

- Improvement (improvement to code)
 
#### Description

- This PR aligns the command implementations with the committer
guidelines. Previously, we had a function that was used only once and
could be inlined to make the code cleaner.

---------

Signed-off-by: Dean Amar <Dean.Amar@ibm.com>

28 of 36 new or added lines in 2 files covered. (77.78%)

12 existing lines in 8 files now uncovered.

10326 of 11297 relevant lines covered (91.4%)

34354.53 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
86.36
 -0.59% cmd/committer/start_cmd.go
2
93.75
 -0.19% cmd/committer/healthcheck_cmd.go

Coverage Regressions

Lines Coverage ∆ File
2
92.48
 0.44% service/vc/validator_committer_service.go
2
88.99
 -1.83% loadgen/adapters/broadcast.go
2
96.72
 1.23% service/coordinator/coordinator.go
2
85.76
 -0.68% service/query/batcher.go
1
94.17
 -0.83% mock/coordinator.go
1
80.19
 1.75% service/sidecar/sidecar.go
1
86.42
 -1.23% loadgen/adapters/verifier.go
1
82.09
 -1.49% utils/utils.go
Jobs
ID Job ID Ran Files Coverage
1 db-test - 29830255468.1 128
79.46
 GitHub Action Run
2 core-db-test - 29830255468.2 98
45.93
 GitHub Action Run
3 unit-test - 29830255468.3 93
84.53
 GitHub Action Run
Source Files on build 29830255468