christophevg / yoker / 29762752245

87%

push

github

refactor: simplify M.2 default tools — bare ALL_TOOLS = [] sentinel per owner's proposal

Replace the over-engineered AllToolsSentinel class (7 dunder methods, 8
scattered isinstance guards) with a bare ALL_TOOLS = [] module-level
sentinel, checked with `is` in exactly ONE place
(Agent._filter_tools_by_definition), then replaced with the actual tool
list from the registry. From there on, tools is just a list — no sentinel
class, no isinstance guards, no typing.cast.

This is the owner's original snippet, implemented as-is. The previous
AllToolsSentinel class was over-engineering despite the owner's clear
proposal.

make check: 1891 tests pass, lint/format/typecheck clean.
Scoped review (round 2): functional, api-architect, security-engineer,
code-reviewer, testing-engineer all approved.

🤖 Implemented together with a coding agent.

1107 of 1267 branches covered (87.37%)

Branch coverage included in aggregate %.

6524 of 7754 relevant lines covered (84.14%)

0.84 hits per line