Freegle / Iznik / 27785

74%

push

circleci

test(search): cover nearbyFeedMsgIDs via browse-scoped search

Coveralls flagged a Go coverage regression on c66acbe0e ("cache the
browse-search reach arm for 60s per member", -0.1% to 83.259%). Traced via
the per-line coverage source (coveralls.io/builds/80661575/source.json)
against the exact commit content: the entire nearbyFeedMsgIDs function
(search.go:187-261) was 0% covered - not just the newly added caching
logic, but the whole reach-universe query it wraps.

Root cause: nearbyFeedMsgIDs only runs when a search request has browse=1,
no groupids, and a member location (the "Nearby" browse-scoped search
path added for Discourse 9933). No existing Go test called the search
endpoint with that combination - search_cache_test.go (added alongside
the caching change) is a DB-free unit test that only covers the cache
helpers directly, and every other search test omits browse=1.

Add an integration test mirroring the fixture pattern already proven in
isochrone_reach_test.go's TestNearbyReachFeed (rippling_reach + viewer
mylocation), calling the search endpoint twice to exercise both the
cache-miss and cache-hit branches of nearbyFeedMsgIDs. Verified locally
via the status API: TestBrowseScopedSearchNearby passes, full suite
3518/3518.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

13215 of 17412 branches covered (75.9%)

Branch coverage included in aggregate %.

138203 of 191641 relevant lines covered (72.12%)

37.96 hits per line