Freegle / Iznik / 27775

74%

push

circleci

fix(ci): don't cancel in-flight post-gate Android builds on newer master commits

check-runner's redundant-pipeline canceller unconditionally kills every
running/on_hold workflow from an older pipeline on the same branch as soon
as a newer commit lands. build-android-modtools-debug (and its dev/debug
siblings) only start after freegle/build-and-test has already passed for
that commit, run on ordinary CircleCI cloud capacity rather than the capped
Katapult pool, and finish quickly — so cancelling them saves no meaningful
CI resource. It only leaves a permanently red "error" GitHub check on an
otherwise-healthy commit, because CircleCI reports "canceled" to GitHub's
legacy commit-status API as "error" (no canceled state exists there).

Reproduced on c66acbe0e: build 27763's build-android-modtools-debug job was
43s into a clean Gradle build (all compile/resource tasks succeeding) when
477980eac landed on master 4 minutes later and the pre-continuation cancel
pass killed its workflow, flipping ci/circleci: build-android-modtools-debug
to state=error at 16:47:29 — matching the job's cancel timestamp exactly.

Add a job-status check before cancelling: if the workflow's currently
running job is one of the post-gate Android builds, leave it to finish
instead of cancelling it.

13217 of 17413 branches covered (75.9%)

Branch coverage included in aggregate %.

138124 of 191641 relevant lines covered (72.07%)

37.94 hits per line