pmd / pmd / 671

79%

Build Type

push

github

Committed by web-flow

Commit Message

[java] fix: IndexOutOfBoundsException for type annotations on inner class method signatures (#6866)

* [java] fix: IOOBE for type annotations on inner class method signatures

The while-loop in handleEnclosingType() was missing a bounds check on
the TypePath length. ASM's TypePath.getStep(i) does pure array
arithmetic with no bounds check of its own.

When the loop consumed the last valid INNER_TYPE step and called getStep
one past the end, it read the high byte of the following type_index
field (the CP index of the annotation type).

That byte equals 1 (= INNER_TYPE) when the CP index is in [256, 511], so
the loop over-incremented selectionDepth and crashed on
enclosingTypes.get(-1).

The regression test uses TestClass, which has 300 dummy fields to push
the Ann descriptor past CP index 255, reliably reproducing the crash.

Fixes #5041.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* [docs] Update release notes

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Sören Glimm <git@uncleowen.de>

Coverage Stats

19235 of 25223 branches covered (76.26%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

41682 of 51692 relevant lines covered (80.64%)

0.81 hits per line