pmd / pmd / 671

Committed 16 Jul 2026 03:07PM UTC coverage: 79.2% (-0.005%) from 79.205%

Build # 671

Build Type

push

github

Committed by

web-flow

Commit Message

[java] fix: IndexOutOfBoundsException for type annotations on inner class method signatures (#6866)

* [java] fix: IOOBE for type annotations on inner class method signatures

The while-loop in handleEnclosingType() was missing a bounds check on
the TypePath length. ASM's TypePath.getStep(i) does pure array
arithmetic with no bounds check of its own.

When the loop consumed the last valid INNER_TYPE step and called getStep
one past the end, it read the high byte of the following type_index
field (the CP index of the annotation type).

That byte equals 1 (= INNER_TYPE) when the CP index is in [256, 511], so
the loop over-incremented selectionDepth and crashed on
enclosingTypes.get(-1).

The regression test uses TestClass, which has 300 dummy fields to push
the Ann descriptor past CP index 255, reliably reproducing the crash.

Fixes #5041.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* [docs] Update release notes

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Sören Glimm <git@uncleowen.de>

Coverage Stats

19235 of 25223 branches covered (76.26%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

41682 of 51692 relevant lines covered (80.64%)

0.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

29.17

/pmd-core/src/main/java/net/sourceforge/pmd/lang/metrics/LanguageMetricsProvider.java

/*
 * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
 */

package net.sourceforge.pmd.lang.metrics;

import java.util.HashMap;
import java.util.Map;
import java.util.Set;

import org.checkerframework.checker.nullness.qual.Nullable;

import net.sourceforge.pmd.lang.LanguageVersionHandler;
import net.sourceforge.pmd.lang.ast.Node;


/**
 * Language-specific provider for metrics. Knows about all the metrics
 * defined for a language. Can be used e.g. to build GUI applications
 * like the designer, in a language independent way. Accessible through
 * {@link LanguageVersionHandler#getLanguageMetricsProvider()}.
 *
 *
 * @author Clément Fournier
 * @since 6.11.0
 */
public interface LanguageMetricsProvider {

    /** Returns the set of all metrics supported by the language. */
    Set<Metric<?, ?>> getMetrics();


    /** Fetch a metric using its name. */
    default @Nullable Metric<?, ?> getMetricWithName(String nameIgnoringCase) {
        for (Metric<?, ?> metric : getMetrics()) {
            for (String nameAlias : metric.nameAliases()) {
                if (nameAlias.equalsIgnoreCase(nameIgnoringCase)) {
                    return metric;
                }
            }
        }
        return null;
    }

    /**
     * Computes all metrics available on the given node.
     * The returned results may contain Double.NaN as a value.
     *
     * @param node Node to inspect
     *
     * @return A map of metric key to their result, possibly empty, but with no null value
     */
    default Map<Metric<?, ?>, Number> computeAllMetricsFor(Node node) {
        Map<Metric<?, ?>, Number> results = new HashMap<>();
        for (Metric<?, ?> metric : getMetrics()) {
            @Nullable Number result = Metric.compute(metric, node, MetricOptions.emptyOptions());
            if (result != null) {
                results.put(metric, result);
            }
        }
        return results;
    }
}

1	/*
2	* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
3	*/
4
5	package net.sourceforge.pmd.lang.metrics;
6
7	import java.util.HashMap;
8	import java.util.Map;
9	import java.util.Set;
10
11	import org.checkerframework.checker.nullness.qual.Nullable;
12
13	import net.sourceforge.pmd.lang.LanguageVersionHandler;
14	import net.sourceforge.pmd.lang.ast.Node;
15
16
17	/**
18	* Language-specific provider for metrics. Knows about all the metrics
19	* defined for a language. Can be used e.g. to build GUI applications
20	* like the designer, in a language independent way. Accessible through
21	* {@link LanguageVersionHandler#getLanguageMetricsProvider()}.
22	*
23	*
24	* @author Clément Fournier
25	* @since 6.11.0
26	*/
27	public interface LanguageMetricsProvider {
28
29	/** Returns the set of all metrics supported by the language. */
30	Set<Metric<?, ?>> getMetrics();
31
32
33	/** Fetch a metric using its name. */
34	default @Nullable Metric<?, ?> getMetricWithName(String nameIgnoringCase) {
35	for (Metric<?, ?> metric : getMetrics()) {	1!
36	for (String nameAlias : metric.nameAliases()) {	1!
37	if (nameAlias.equalsIgnoreCase(nameIgnoringCase)) {	1!
38	return metric;	1✔
39	}
UNCOV 40	}	×
UNCOV 41	}	×
42	return null;	×
43	}
44
45	/**
46	* Computes all metrics available on the given node.
47	* The returned results may contain Double.NaN as a value.
48	*
49	* @param node Node to inspect
50	*
51	* @return A map of metric key to their result, possibly empty, but with no null value
52	*/
53	default Map<Metric<?, ?>, Number> computeAllMetricsFor(Node node) {
54	Map<Metric<?, ?>, Number> results = new HashMap<>();	×
55	for (Metric<?, ?> metric : getMetrics()) {	×
56	@Nullable Number result = Metric.compute(metric, node, MetricOptions.emptyOptions());	×
57	if (result != null) {	×
58	results.put(metric, result);	×
59	}
60	}	×
61	return results;	×
62	}
63	}

pmd / pmd / 671

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous