29507284342
91%
main: 91%

Ran 16 Jul 2026 02:38PM UTC

Jobs 3

Files 129

Run time 1min

Badge

Embed ▾

Committed 16 Jul 2026 02:33PM UTC coverage: 91.436% (-0.3%) from 91.699%

Build # 29507284342

Build Type

Pull #677

github

Committed by

liran-funaro

Commit Message

[test] fix flaky TestSignatureVerifierManagerPolicyUpdateAndRecover

Batch submission ran inside require.Eventually/require.Never conditions.
testify runs the condition in its own goroutine and, once waitFor
elapses, returns without waiting for it. submitTxBatch blocks on a full
input channel, so a condition that submitted leaked a goroutine past the
assertion that then (1) submitted stray batches into a later phase of the
test and (2) raced on the reassigned verifierStreams variable (an
observed data race). The stray flooding also kept signVerifier[0] parked
on a channel write, so a stopped server went undetected within the 30s
window and the connection metric stayed Connected.

Submit batches from a dedicated background goroutine that is started
before, and stopped after, each require.Eventually/require.Never, and
keep the conditions side-effect-free (pure reads of atomics and stable
locals). t.Cleanup tears the submitter down even if the test fails first.

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #677: [test] fix flaky TestSignatureVerifierManagerPolicyUpdateAndRecover

Coverage Stats

10420 of 11396 relevant lines covered (91.44%)

42822.71 hits per line

Coverage Regressions

Lines	Coverage	∆	File
15	78.29	-2.91%	service/sidecar/sidecar.go
6	84.7	-1.64%	service/vc/database.go
4	88.31	-2.6%	service/vc/committer.go
4	91.27	-1.75%	service/vc/validator_committer_service.go
4	86.24	-3.67%	loadgen/adapters/broadcast.go
2	92.35	-0.53%	mock/orderer.go
1	97.5	2.5%	mock/coordinator.go
1	94.95	-1.01%	loadgen/adapters/common.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	db-test - 29507284342.1	16 Jul 2026 02:40PM UTC	129	79.64	GitHub Action Run
2	unit-test - 29507284342.2	16 Jul 2026 02:41PM UTC	93	83.57	GitHub Action Run
3	core-db-test - 29507284342.3	16 Jul 2026 02:38PM UTC	100	45.16	GitHub Action Run

hyperledger / fabric-x-committer / 29507284342
91%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29507284342

hyperledger / fabric-x-committer / 29507284342 91% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29507284342

hyperledger / fabric-x-committer / 29507284342
91%
main: 91%

README BADGES
x