hyperledger / fabric-x-committer / 29421861922

92%

Build Type

push

github

Committed by web-flow

Commit Message

[coordinator] fix deadlock waiting for pending transactions (#649)

#### Type of change

- Bug fix

#### Description

While the sidecar stream is inactive, the VC keeps filling the
coordinator's
bounded status queue, but its only drainer (`sendTxStatus`) is gone with
the
stream. If the in-flight backlog exceeds the queue capacity, the VC
blocks on the
full queue and recovery deadlocks: the sidecar won't reconnect until
`NoPendingTransactionProcessing` reports idle, which can't happen while
the VC is
blocked.

Fix by draining and discarding queued statuses in
`NoPendingTransactionProcessing`
(polled during recovery). This unblocks the VC so it can finish.
Discarding is
safe — statuses are durable in the state DB and recovered via
`GetTransactionsStatus`, never from this queue.

Adds a regression test reproducing the deadlock.

#### Related issues

 - resolves #616

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

16 existing lines in 5 files now uncovered.

10450 of 11396 relevant lines covered (91.7%)

43269.12 hits per line