decentraland / social-service-ea / 29113386552

90%

push

github

feat: inform clients why a subscription stream is closed (#432)

* feat: inform clients why a subscription stream is closed

Uses the new SubscriptionStreamClosed message from @dcl/protocol: before a
server-initiated close, the stream now yields a final message carrying a
close reason (and optional detail) instead of ending silently.

- emitterToGenerator: destroy() accepts an optional close reason, exposed
  via getCloseReason() so the consumer loop can act on it after draining.
- subscribers-context: teardown paths tag their reason — SERVER_SHUTTING_DOWN
  on stop, STALE_SUBSCRIPTION on both reconciliation sweeps — and
  removeConnection() forwards an optional caller-provided reason.
- handleSubscriptionUpdates: rejected duplicate subscriptions now tell the
  client why (DUPLICATE_SUBSCRIPTION) before closing, and destroys with a
  reason yield a final stream-closed message when the service provides a
  builder for it.
- All six subscribe services build the final message with fromPartial so it
  is protobuf-complete (zero-value defaults plus the notice).

Delivery is best-effort by nature: the final message only reaches clients
whose connection is still alive (duplicate rejection, shutdown drain);
teardowns triggered by an already-dead socket have no one to inform.

* refactor: drop undeliverable subscription stream close reasons

Only the duplicate-subscription rejection can actually deliver a close notice —
the connection is still alive there. Shutdown and stale-cleanup closes run after
the socket is gone, so their reasons never reached the client. Remove that dead
plumbing: the close-reason parameter on emitterToGenerator's destroy() (and its
getCloseReason accessor), the reason threading through subscribers-context
teardown paths, and the post-loop reason forwarding in handleSubscriptionUpdates.

The duplicate-subscription path (the one that works) is unchanged.

* chore: bump @dcl/protocol to the trimmed stream-close-reason build

Repoints to t... (continued)

2354 of 2761 branches covered (85.26%)

Branch coverage included in aggregate %.

12 of 13 new or added lines in 7 files covered. (92.31%)

5881 of 6356 relevant lines covered (92.53%)

80.45 hits per line