akvo / akvo-mis / #741

89%

push

coveralls-python

[#262] Allow empty answers when syncing draft submissions (#264)

* [#262] Allow empty answers when syncing draft submissions

- Move is_draft parameter parsing earlier in sync_pending_form_data
- Allow empty answers dict only when is_draft=true query param is set
- Add fallback to empty dict when answers is null/missing for drafts
- Add test for blank draft sync (user exits form without entering data)
- Add test to verify non-draft submissions still require answers

This fixes the 400 error when mobile app syncs a draft after user
exits a form without filling any fields.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix is_draft parsing and serializer validation for draft sync endpoint

- Use params.validated_data['is_draft'] instead of re-parsing from
  request.GET, eliminating duplicate logic and potential inconsistency
  (e.g. ?is_draft=TRUE passing serializer but treated as non-draft)
- Remove SyncDeviceFormDataSerializer.validate empty-answers check and
  make answers optional (required=False, default=dict) so the OpenAPI
  schema matches actual behavior: answers optional for drafts, required
  for non-drafts (enforced at view level)

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

5686 of 6594 branches covered (86.23%)

Branch coverage included in aggregate %.

10699 of 11924 relevant lines covered (89.73%)

0.9 hits per line