Freegle / Iznik / 27249

76%

master: 72%

push

circleci

fix(modtools): standard-message Reject on a rippled-in copy scopes like the button (9862/16-17)

On a rippled-in copy the Reject BUTTON already does the right thing - the "stop
this post appearing on your community" confirmation, a scoped removal from just
this group, and no message to the member. But a standard message with
action=Reject went through the compose modal instead: it sent a message and did a
full (global) reject. A mod using a local standard message therefore got a
different dialog and a "Rejected" (not scoped) outcome (Discourse 9862/16-17).

Route a standard message whose action is Reject, on a rippled-in copy, through the
same scoped path as the button (ModMessageButton.click): show the no-message
confirmation and reject scoped to this group, with no message to the member. Only
take this DESTRUCTIVE scoped path when the action is DEFINITIVELY 'Reject' - if the
standard message can't be resolved we fall through to the compose modal (fail
closed; the fail-open handling of an unknown action is what closed PR #1071). Also
pass is-home-group to the standard-message buttons (previously only the Reject
button got it, so they defaulted to home-group and never scoped).

5618 of 8536 branches covered (65.82%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 2 files covered. (100.0%)

63748 of 82341 relevant lines covered (77.42%)

87.06 hits per line