Freegle / Iznik / 27245

72%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(ripple): name the "quicker to get to" note's points with in-group postcodes

The reach moderator note ("This post is quicker to get to for Freeglers in P
than P is to Q") named its P/Q points with Location::describeNearest, which
returns the globally-nearest postcode with no group constraint. For a point near
the group's edge that landed on a NEIGHBOURING group's postcode - a Hackney mod
saw Islington/Newham postcodes "justifying" the ripple (Discourse 9808/583).

Add Location::describeNearestInGroup(lat, lng, groupid): take the nearest few
postcodes and keep the nearest one that is inside the group's polyindex polygon
(matching groupsNear's containment test), falling back to the unconstrained
nearest if none are in-group or the group has no usable polygon. Use it for the
P/Q points in ProximityNotesCommand.

Coverage Stats

13055 of 17207 branches covered (75.87%)

Branch coverage included in aggregate %.

23 of 25 new or added lines in 2 files covered. (92.0%)

2 existing lines in 2 files now uncovered.

136535 of 189627 relevant lines covered (72.0%)

37.84 hits per line