Freegle / Iznik / 27236

72%

push

circleci

fix(chat): filter retry-duplicate messages on read (Discourse 9913)

A chat send goes through useFetchRetry, which retries the POST on a network
error or a 5xx - neither of which proves the write failed. If the original POST
reached the server but its response was lost, the retry inserts a SECOND, real
chat_messages row (different id, identical content). The batch
cleanup:chat-duplicates cron removes one later, but until then the sender sees
two copies of their message (Jeni's report: two copies that "disappeared" once
the cron ran).

Rather than a schema change, dedupe on read in the chat store's fetchMessages:
drop a later row when it has the SAME author and byte-identical content (message,
type, refmsgid, refchatid, imageid, addressid, modnote - not just the text, so
two genuinely-different messages that share text are never merged) AND is within
the retry window of an earlier kept row. Rows with no valid timestamp are never
deduped (the window can't be established). Covers direct member chat and the
ModTools per-room panes, which share fetchMessages.

13054 of 17205 branches covered (75.87%)

Branch coverage included in aggregate %.

59 of 59 new or added lines in 1 file covered. (100.0%)

136515 of 189604 relevant lines covered (72.0%)

37.81 hits per line