dangernoodle-io / breadboard / 29372528467

96%

push

github

fix: close HTTP status fail-silent class, not just missing 413 (B1-954) (#871)

bb_http_resp_set_status rejected any status code not in
bb_http_status.c's SSOT table (BB_ERR_INVALID_ARG, status left unset).
bb_ota_push.c called it with 413 on an oversized OTA upload and ignored
the return, so the client got a default status instead of 413. The same
hole previously existed for 501 (only caught by luck in PR #868).

- add 413 to the table (the proximate fix)
- add bb_http_status_line(): a known code returns the same reason
  string; an untabled code now falls back to a numerically-correct
  generic line instead of leaving the status unset, and logs a warning
  so the missing entry gets noticed. Only the number is client-visible;
  the phrase is cosmetic, so the fallback can't regress prior behaviour.
- host and espidf bb_http_resp_set_status backends both route through
  the fallback; espidf uses a small round-robin buffer pool since
  httpd_resp_set_status stores the string pointer (no copy) and an SSE
  async handler can run concurrently with the main httpd task
- audited every bb_http_resp_set_status call site (components/,
  platform/, test/) against the table: 413 was the only gap
- tests assert the emitted status (not set_status's return value) for
  413, an untabled code, and a 501 regression guard


Claude-Session: https://claude.ai/code/session_01V5JXJNaYWPwjrcS8nk183m

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

6928 of 7567 branches covered (91.56%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 2 files covered. (100.0%)

11622 of 11890 relevant lines covered (97.75%)

2430.08 hits per line