dangernoodle-io / breadboard / 29371908901

96%

push

github

refactor: migrate bb_diag_panic.c off bb_nv to bb_config/bb_storage (B1-756) (#870)

Last live bb_nv generic-KV call site in the tree -- migrates the
abnormal-reset counter's 2 simple KV calls to bb_config_get_u32/set_u32
and the 2-key transactional update (app fingerprint + reset count) to
bb_storage_txn_begin/set/commit. Unblocks bb_nv deletion, which gates
bb_json -> bb_response -> the serialization epic.

- adds requires=storage_nvs to bb_diag_panic_init's bbtool:init marker:
  bb_storage_txn_* requires the "nvs" backend already registered, unlike
  the bb_nv forwarders it replaces which called nvs_open/nvs_set_* directly
  and had no such ordering dependency (same edge as bb_wifi_autoinit)
- bb_config_get_u32 leaves *out untouched on a non-BB_OK return unless
  has_default resolves a NOT_FOUND (bb_nv_get_u32 always wrote the
  fallback) -- both fields set has_default=true/def.u32=0 explicitly and
  callers check the return code rather than relying on zero-init
- bb_storage_txn_set(..., BB_STORAGE_ENC_U32, ...) preserves the existing
  NVS native-U32 on-flash type for both keys (bb_diag/reset_count,
  bb_diag/app_fp) -- byte-compatible, no orphaned values
- bb_diag's CMakeLists.txt gains an explicit bb_storage PRIV_REQUIRES
  (bb_diag_panic.c now calls bb_storage_txn_* directly, previously only
  transitively available via bb_config.h); bb_nv stays PRIV_REQUIRES for
  bb_diag_routes.c's SSOT namespace/key headers

Codegen composition-root proof: with the requires=storage_nvs edge,
bb_storage_nvs_register() is ordered before bb_diag_panic_init() in the
generated bb_app_init() early tier (verified via bbtool codegen
--components bb_diag,bb_storage_nvs,...).

6917 of 7556 branches covered (91.54%)

Branch coverage included in aggregate %.

11610 of 11879 relevant lines covered (97.74%)

2435.11 hits per line