dangernoodle-io / breadboard / 29343248147

95%

push

github

refactor: move display/mdns/update-check flags from bb_nv to bb_settings (B1-750) (#862)

Moves display_enabled, mdns_enabled, and update_check_enabled from bb_nv
(platform/espidf/bb_nv/bb_nv.c) to bb_settings, following the
hostname/timezone precedent (B1-754/B1-750). Byte-compat preserved: same
NVS namespace "bb_cfg", same keys "display_en"/"mdns_en"/"update_check_en",
same nvs_get_u8/nvs_set_u8 (BB_CONFIG_BOOL -> BB_STORAGE_ENC_U8) encoding.
Default-when-unset stays true (display/mdns/update-check on) for all three,
with fail-open-to-true on a real backend I/O error too, matching bb_nv's
prior "nvs_get_u8(...) != ESP_OK -> default 1" behavior exactly.

- bb_display_info.c: bb_nv_config_display_enabled() -> bb_settings_display_enabled_get()
- bb_ota_check_common.c: update_check_enabled get/set -> bb_settings equivalents
- mdns_enabled has zero production consumers today (uncomposed, not dead) --
  moved as-is per B1-750 scope
- provisioned flag untouched (deferred to the creds cluster, B1-935)

Dropping display_en/mdns_en/update_check_en from bb_nv's s_bb_cfg_keys[]
manifest table removes them from /api/manifest -- a known, accepted gap
(B1-936); bb_settings has no manifest registration yet.


Claude-Session: https://claude.ai/code/session_01V5JXJNaYWPwjrcS8nk183m

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

6893 of 7531 branches covered (91.53%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 2 files covered. (100.0%)

11575 of 11850 relevant lines covered (97.68%)

2409.28 hits per line