dangernoodle-io / breadboard / 29345082890

96%

push

github

refactor: move reboot-record from bb_nv to bb_system (B1-750) (#863)

bb_nv_reboot_record_save relocates to bb_system as
bb_system_reboot_record_save (components/bb_system/src/bb_system_reboot_record.c),
consistent with bb_system already owning the reboot-reason SSOT (B1-532)
and boot-count (B1-753) under the same NVS namespace.

Preserved byte-for-byte: namespace BB_REBOOT_NVS_NS ("bb_reboot"),
keys BB_REBOOT_KEY_LAST ("last") / BB_REBOOT_KEY_HISTORY ("history"),
and the delimited-string record encoding (bb_reboot_record_encode,
unchanged in bb_core). Only the persist-glue function moved; its body,
signature, and behavior are unchanged.

bb_nv_routes.c's factory-reset path now calls bb_system_reboot_record_save
(via a new bb_nv PRIV_REQUIRES bb_system — a small PRIV_REQUIRES-only
cycle with bb_system's existing PRIV_REQUIRES bb_nv, resolved automatically
by the linker per ESP-IDF's documented circular-dependency handling;
verified across all 5 smoke boards). Factory-reset's NVS erase / RTC
mirror invalidation / esp_restart() sequencing is untouched.

Tests migrated from test_nv_generic.c to test_bb_system.c
(test_bb_system_reboot_record_save_round_trips_via_get_str,
test_bb_system_reboot_record_save_null_detail), renamed to the new
symbol, no behavior change.


Claude-Session: https://claude.ai/code/session_01V5JXJNaYWPwjrcS8nk183m

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

6893 of 7531 branches covered (91.53%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

11575 of 11850 relevant lines covered (97.68%)

2464.31 hits per line