dangernoodle-io / breadboard / 29340296252

96%

push

github

refactor: move timezone from bb_nv to bb_settings (B1-750) (#861)

Adds bb_settings_timezone_get/set, mirroring the hostname accessor's
size-probe/truncation contract and NULL-safe out_len guarantee. Preserves
the exact NVS namespace "bb_cfg" and key "timezone" bb_nv_config used
(BB_NV_CONFIG_NVS_NS + BB_NV_KEY_TIMEZONE), so already-provisioned boards
keep their stored timezone byte-for-byte.

Migrates bb_ntp's two production call sites (espidf + host) off
bb_nv_config_timezone/bb_nv_config_set_timezone, dropping bb_nv from
bb_ntp's PRIV_REQUIRES entirely (bb_ntp used nothing else from bb_nv).
Deletes bb_nv_config_timezone/bb_nv_config_set_timezone, their manifest
entry, and the timezone field from bb_nv's s_config -- no callers remain.

Timezone was never part of bb_nv's RTC_NOINIT creds mirror (ssid/pass/
provisioned only), so this stays clear of the RTC hazard area.


Claude-Session: https://claude.ai/code/session_01V5JXJNaYWPwjrcS8nk183m

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

6887 of 7525 branches covered (91.52%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 2 files covered. (100.0%)

11557 of 11832 relevant lines covered (97.68%)

2393.15 hits per line