dangernoodle-io / breadboard / 29317409723

96%

push

github

fix: close fence identity-collision hole and platform-only depends gap (#859)

B1-917: fence/_base.py's diff() ratcheted on identity presence/absence
only, so a second occurrence reusing an already-baselined identity
(path-insensitive by design, for rename-stability) collapsed invisibly
onto the existing entry -- "0 new -- PASS" even when a genuine new
hand-rolled clamp/sat_sub/callback_slot instance landed. diff() now
ratchets on occurrence COUNT per identity (derived from the existing
baseline entries -- no format change needed), closing the hole while
preserving pure-rename stability. fence_cmd.py's --update-baseline
prune now matches exact baseline entries rather than pruning every
entry sharing an identity, so a partial count-shrink no longer drops
surviving occurrences. Grandfathered one pre-existing real occurrence
the fix now correctly surfaces (components/bb_mqtt_client/include/
bb_mqtt_client.h's CONFIG_BB_MQTT_CLIENT_AUTOREGISTER #if guard,
previously invisible to the ratchet) into .baseline/bbtool/fence/
di_legacy.json as a deliberate, reviewed one-time addition -- not via
--update-baseline, which stays incapable of blessing net-new markers.

diff()'s candidate selection now pairs markers by EXACT PATH first
(same path on both sides = same occurrence, neither new nor removed);
only the leftovers become new/removed candidates, with any remaining
cross-side leftovers paired off deterministically as ambiguous renames
before the true count surplus/deficit is reported. This fixes a
path-misattribution bug where a rename coinciding with a genuine
add/remove under the same identity named the WRONG FILE (reviewer
finding), which mattered because --update-baseline acts on the
reported Marker objects.

B1-903: boards.py's derive_component() only ever read
components/<name>/CMakeLists.txt for REQUIRES/PRIV_REQUIRES, so a
platform-only component (no components/<name>/ dir at all, e.g.
bb_event_routes_espidf) declaring its own idf_component_register(..... (continued)

6897 of 7535 branches covered (91.53%)

Branch coverage included in aggregate %.

11604 of 11879 relevant lines covered (97.68%)

2446.36 hits per line